Correctly check scripts that must inherit EditorPlugin
#85271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates some error messages related to this kind of check across the codebase.
YuriSizov
force-pushed
the
core-check-please!
branch
from
0f151a3 to
bc1949d
Compare
YuriSizov
added
the
cherrypick:4.2
dsnopek
approved these changes
Nov 30, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85268. There is a similar case with the visual shader editor plugin and
VisualShaderNodeCustom, but I'm not familiar enough with this part to make a call if these need to be similarly updated.I also noticed some related error messages were incorrect, poorly phrased, or too terse. So I updated some of them across the codebase.