Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't insert newline while saving #85228

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 22, 2023

Follow-up to #85154

Changes the new check into an error; saving while saving is now invalid behavior. I tweaked Script Editor to avoid the new error. There might be some cases when the newline is not applied correctly, but it's probably rare and harmless. Saving script in Script Editor does call apply_changes().

@KoBeWi KoBeWi added this to the 4.3 milestone Nov 22, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner November 22, 2023 16:37
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Might be worth rebasing as it's been 7 months.

@KoBeWi KoBeWi force-pushed the don't_save_scene_when_saving_script_while_saving_scene branch from 3d05f72 to b70368b Compare June 26, 2024 11:22
@akien-mga akien-mga merged commit b0c7f45 into godotengine:master Jun 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the don't_save_scene_when_saving_script_while_saving_scene branch June 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants