Fix crash caused by conflicting menu option IDs #85227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 22, 2023
|
I should've spotted it earlier, but technically any change to this enum could create conflicts with user projects if they extend and customize the resource picker. We expose hooks to add custom options to this menu and users can provide any IDs they want. We should probably suggest they use some safe range with a high base number in the documentation. As far as this PR, it should be fine (user projects can't extend script and shader pickers), and starting with 10 was a bit... optimistic on my part 🙃 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #85150
Trying to make new Script or new Shader was interpreted as Show in Filesystem (which shifted to 10) and resulted in
get_path()call on null resource.