Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a handful of minor adjustments all revolving around mypy
.gitignore
to explicitly handle the mypy cache after running the mypy test script (or mypy in general)no_implicit_optional = True
. This is because mypy made this their default value in later versions1, so adding a rule one way or the other clears up ambiguity for mypy installed from other sources (eg: vscode extension)no_implicit_optional = True
. While they could've been left alone if the value was changed tofalse
, all cases of changed arguments were right beside another argument that was already using an explicit optional wrapper; as such, the changes were sensible in-context & just so happened to be the only offending areas in the entire repo to begin withFootnotes
https://github.com/hauntsaninja/no_implicit_optional#whats-going-on ↩