[Core] Prevent copying of SelfList and SelfList::List

[AThousandShips]

Copying of these types is unsafe and should be detected

Also removed unnecessary constructors for TileMap DebugQuadrant and RenderingQuadrant which used copying of SelfList::List

Bug identified while researching:

• Godot tilemaps are extremely unstable and cause crashes all the time #84892

Unable to reliably replicate this crash so can't confirm this is a fix, will continue to investigate that fix

[AThousandShips]

The TileMap data types should not be a problem with this as they are RefCounted and therefore never invoke their copy constructor

[akien-mga]

Thanks!

[AThousandShips]

Thank you!

[groud]

The TileMap data types should not be a problem with this as they are RefCounted and therefore never invoke their copy constructor

Did you verify that ? Because, as far as I remember, those constructors were needed to avoid several issues. Though I guess forbidding the copy as you did would probably trigger a compilation error 🤔 .

Anyway, that was just to mention this is probably something we need to keep an eye on.

I am not sure why

[AThousandShips]

I did both by compilation and by that there's no such semantics in the engine, they're created and shared, not copied, were these data elements always ref counted? Looks like a remnant of a version not using that

[groud]

were these data elements always ref counted? Looks like a remnant of a version not using that

Ah that's a good point, that might be it! Good call.

[AThousandShips]

If the two quadrant types were built from the old TileMapQuadrant then that's probably why, it was non-ref counted and had a copy assignment with the same comment 🙂