-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCons: Add two new COMSTR
environment variables
#85153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you give some examples of the effect of these changes? |
Sure! RCCOMSTRBefore:
After:
GENCOMSTRBefore:
After:
|
6109bac
to
0ce9b6f
Compare
Calinou
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
akien-mga
approved these changes
Mar 4, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the output logs of a non-verbose build more uniform by adding two new environment variables:
RCCOMSTR
andGENCOMSTR
.RCCOMSTR
is an existing keyword for SCons, used for compiling.rc
files into.res
/.o
, so adding it eliminates the last remaining verbose output (on Windows anyway).GENCOMSTR
is a bit more involved, as it effectively replaces themethods.Run
"short_message" argument. However, because it's now formatted to automatically reference the generated file, the original messages are no longer needed