Fix issue with 3D scene drag and drop preview node #85087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:4.2
YuriSizov
suggested changes
Nov 21, 2023
There was a problem hiding this comment.
This ignores the checks, which I don't think is correct. The same code existed in the canvas item editor (in fact, it was copied here from there), and the same issue was identified there. It was fixed in #15516, and I think you should do the same here.
Introduce a new bool, set it to true in place of the line that you've removed, and then only call add_child if it is set to true. You can see how it's done in the linked PR.
EelisOtsamo
force-pushed
the
fix_scene_drag_and_drop
branch
2 times, most recently
from
0b65f20 to
58dc662
Compare
EelisOtsamo
force-pushed
the
fix_scene_drag_and_drop
branch
from
58dc662 to
834ccb9
Compare
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84422
Fixes a bug with drag and dropping multiple scenes in the 3D editor. The preview node was previously being parented inside the loop that iterated over the selected files to drag, when it only had to be parented once.