Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary assignments #85071

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Remove unnecessary assignments #85071

merged 1 commit into from
Dec 14, 2023

Conversation

Rubonnek
Copy link
Member

This patch mostly simplifies some Vector or HashMap accesses detected in #84445.

@Rubonnek Rubonnek added this to the 4.x milestone Nov 18, 2023
@Rubonnek Rubonnek requested review from a team as code owners November 18, 2023 22:50
@Rubonnek Rubonnek mentioned this pull request Nov 18, 2023
Merged
AThousandShips
AThousandShips approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These looks good (just confirming my own suggestions so someone else should confirm as well)

scene/main/resource_preloader.cpp Outdated Show resolved Hide resolved
@Rubonnek Rubonnek force-pushed the remove-unnecessary-assignments branch from 7a21671 to 6aba5db Compare November 19, 2023 14:46
@YuriSizov
Copy link
Contributor

Looks fine to me, aside from the two things that I've mentioned. Once addressed, this can be merged.

@YuriSizov YuriSizov modified the milestones: 4.x, 4.3 Dec 13, 2023
@Rubonnek @AThousandShips
Remove unnecessary assignments
80fb8db 
Co-authored-by: A Thousand Ships <[email protected]>
@Rubonnek Rubonnek force-pushed the remove-unnecessary-assignments branch from 6aba5db to 80fb8db Compare December 13, 2023 16:06
@YuriSizov YuriSizov merged commit 203c8c3 into godotengine:master Dec 14, 2023
15 checks passed
@Rubonnek Rubonnek deleted the remove-unnecessary-assignments branch December 14, 2023 16:46
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Rubonnek @YuriSizov @AThousandShips