Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisualShader: Refactor use of Connection #84969

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

alesliehughes
Copy link
Contributor

As discussed previously, refactor some code.

@alesliehughes alesliehughes requested a review from a team as a code owner November 16, 2023 10:46
@Calinou Calinou added this to the 4.x milestone Nov 16, 2023
@akien-mga akien-mga changed the title Visual shader refacter use of connection Visual shader refactor use of connection Nov 16, 2023
@akien-mga akien-mga changed the title Visual shader refactor use of connection VisualShader: Refactor use of Connection Nov 16, 2023
@AThousandShips
Copy link
Member

For posterity please link to where this was discussed, assuming it was in a PR

@QbieShay QbieShay requested a review from Chaosus November 16, 2023 16:36
@alesliehughes
Copy link
Contributor Author

It was in #84832

@alesliehughes alesliehughes force-pushed the shader_refactor branch 2 times, most recently from b1834ff to d5e3e62 Compare December 11, 2023 20:36
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Dec 11, 2023
@akien-mga akien-mga merged commit 4450ae9 into godotengine:master Dec 11, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants