-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch theme editor items from ThemeDB #84763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase, but otherwise looks good.
Do you think we leave any performance on the table by switching from a method pointer to get_theme_item_list
? I know this is needed for ThemeDB
anyway, so it's fine. But I'm not well versed in C++ so curious what your take is here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, as I was testing #84760, I realized there is something wrong will all 3 PRs. While we can use get_class_own_items
in the docs (and in fact we should), for the theme editor, the override list, and the argument autocompletion we need to include inherited items as well.
This requires a new get_class_items
method, which returns not just own items. Plus we need a method to get such items filtered based on the data type, as outlined above. I think one of these PRs need to do all this groundwork, and then others can be built on top of it.
Let me know if you need any help with any of that.
PS. If you need an example of this being a problem, check CheckBox for instance.
287a11f
to
e86750d
Compare
Updated. I added yet another argument to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine to me.
Thanks! |
Together with #84760 fixes #82402