Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan the filesystem in the first frame when using headless mode #84570

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Nov 7, 2023

Tentative fix for #84460

I tested with a larger project that uses GDExtension. My testing procedure was as follows:

  1. delete extension_list.cfg
  2. Run godot --path test/project --headless --editor --quit using master (extension_list.cfg was not generated and I got a warning: WARNING: Scan thread aborted...)
  3. Run godot --path test/project --headless --editor --quit-after 100 using master (Same results as before. Since this is a larger project, I imagine the delay would need to be larger as well)
  4. godot --path test/project --headless --editor --quit using this PR (the extension_list.cfg file is generated right away)

@clayjohn clayjohn added this to the 4.2 milestone Nov 7, 2023
@clayjohn clayjohn marked this pull request as ready for review November 7, 2023 10:15
@clayjohn clayjohn requested review from dsnopek and YuriSizov November 7, 2023 10:17
@YuriSizov YuriSizov merged commit 3e7f638 into godotengine:master Nov 7, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks! David should confirm with his own testing, but this is exactly what the behavior was prior to the recent changes. So it should be good.

@dsnopek
Copy link
Contributor

dsnopek commented Nov 7, 2023

Thanks! I tested locally and it seems to be working. Waiting to see if it works with godot-cpp's CI as well - see PR godotengine/godot-cpp#1304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants