Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCons: Fix build with GDScript LSP disabled #84191

Merged
merged 1 commit into from
Oct 31, 2023
Merged

SCons: Fix build with GDScript LSP disabled #84191

merged 1 commit into from
Oct 31, 2023

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga added this to the 4.2 milestone Oct 30, 2023
@akien-mga akien-mga requested a review from a team as a code owner October 30, 2023 14:29
@akien-mga akien-mga requested a review from a team October 30, 2023 15:41
@akien-mga akien-mga merged commit 8c7f836 into godotengine:master Oct 31, 2023
15 checks passed
@akien-mga akien-mga deleted the scons-gdscript-fix-no-lsp-build branch October 31, 2023 19:21
@timothyqiu
Copy link
Member

The original PR has a 3.x version #82025. This needs to be cherry-picked too :)

@timothyqiu timothyqiu added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 10, 2024
@akien-mga
Copy link
Member Author

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug regression topic:buildsystem topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Cannot build Godot with most modules disabled - error in linking step
2 participants
@akien-mga @timothyqiu