Fix retrieving command line flags in Android.

[MTareqAzim]

Fixes #80574

This fix stemmed from immersive mode not working in Godot 4.2. It was caused by the command line flags not properly being retrieved.

In this case, the strings retrieved were not properly added to the ArrayList. I do not know Kotlin, so it took time for me to find this fix, but that also means there might be a better fix than this one.

[Calinou]

Tested locally, it works as expected on a Samsung Galaxy Z Fold4 (Android 13).

Testing project: test_android_immersive_mode.zip

Before1	After (this PR)

APKs for testing:

• master: UnnamedProject_master.zip
• This PR: UnnamedProject_pr_84102.zip

Footnotes

1. Showing notification bar is disabled on screenshots in my system settings, but notice how the image is less tall due to some space being taken by the notification bar. ↩

[akien-mga]

The fix seems correct, but to make it cleaner, I would suggest removing the argc argument from var cmdline = ArrayList<String>(argc).

This seems to be a misinterpretation of the API, this argument is called initialCapacity but it doesn't actually resize the ArrayList. It's not clear what it does, but it might be that it doesn't do anything actually: https://stackoverflow.com/a/45661667

I confirm that this program prints an empty array:

fun main() {
    var argc = 4
    val cmdline = ArrayList<String>(argc)
    println(cmdline)
}

I checked and that's the only occurrence of using the optional initialCapacity parameter in our Kotlin codebase.

Note: Please make modifications by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow).

[m4gr3d]

@MTareqAzim Thanks for the fix!
The original type of cmdLine was Array<String> for which the addition as previously done worked.
The switch to ArrayList<> changed the semantics, introducing the bug.

[m4gr3d]

The fix seems correct, but to make it cleaner, I would suggest removing the argc argument from var cmdline = ArrayList<String>(argc).

This seems to be a misinterpretation of the API, this argument is called initialCapacity but it doesn't actually resize the ArrayList. It's not clear what it does, but it might be that it doesn't do anything actually: https://stackoverflow.com/a/45661667

I confirm that this program prints an empty array:

fun main() {
    var argc = 4
    val cmdline = ArrayList<String>(argc)
    println(cmdline)
}

I checked and that's the only occurrence of using the optional initialCapacity parameter in our Kotlin codebase.

Note: Please make modifications by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow).

The ArrayList data structure has an internal array it uses to store data that is dynamically resized. The initialCapacity argument is used to pre-allocate the size of that array, which is useful if you know how big it can grow to, avoiding re-allocation, which involves resizing and copying the original array.

As such, let's leave the original allocation as it was. For most operation it won't make a difference since the default initial capacity is 10, and the argument count is likely to be smaller or equal to that, but in occasional situation, it may be useful.

[m4gr3d]

Looks good!

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉