Refactor the parsing of port names in visual shader's expressions #83956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 25, 2023
Chaosus
force-pushed
the
vs_expression_parsing
branch
2 times, most recently
from
cea88b8 to
92da7ca
Compare
Geometror
approved these changes
Mar 21, 2024
Chaosus
force-pushed
the
vs_expression_parsing
branch
from
92da7ca to
aa12241
Compare
|
Yes, thanks @Geometror, I think I've completed with all of your remarks. |
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
Refactor the parsing of port names in visual shader's expressions
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to rewrite that part of the code to prevent further exclusion of control symbols (and easing up the code itself by removing the needing of running multiple loops for each symbol).
Now, only the symbols (before and after the expression) which may be a part of other identifiers (underscore symbol '_', A-Z, a-z, 0-9) will make the string replacing of port names in the expression to be failed.