-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that some ParticleProcessMaterial
properties have effect over the lifetime
#83606
Clarify that some ParticleProcessMaterial
properties have effect over the lifetime
#83606
Conversation
Why remove the additional documentation about how it works with a CurveXYZTexture? |
@akien-mga Hmmm, I forgot I am working on the scale, right, I will fix it |
b52f4ec
to
8ac05d3
Compare
Signed-off-by: Saif Kandil <[email protected]>
I think it needs to apply to other properties like damping as well, but it needs to be double-checked first |
ParticleProcessMaterial.scale_curve
does
ParticleProcessMaterial.scale_curve
doesParticleProcessMaterial
properties have effect over the lifetime
This PR should probably be updated to include more properties other than |
Hmmmm, sure I mean why not, is there any other properties needed, I see we need the damping as well, is there anything else I am not aware of? |
I looked at the whole list and it seems like the following properties seem to forget to mention the "over its lifetime" part.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR itself is completely fine. As I said before, I just wish it tackled more properties (which can be done later).
I had no "qualification" to approve it previously, but I can now.
I can add them some time anyway. Btw congrats for being able to approve now 🎉🎉🎉 |
Thanks! |
Fixes #83603