Re-add close button for nodes in AnimationNodeBlendTree editor
#83507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaracenOne
requested changes
Oct 19, 2023
akien-mga
reviewed
Oct 21, 2023
|
Thanks! |
akien-mga
changed the title
AnimationNodeBlendTree editorAnimationNodeBlendTree editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82501
The close/delete button was removed intentionally from these editors. Users are supposed to use context menu delete option or the
DELkey. However, there was no "Delete" option inAnimationNodeBlendTreeeditor's context menu. The only way to delete a node was usingDELkey, but it's hard to discover.My initial thought was to add the missing "Delete" option. But the right click menu in this editor was actually not a standalone context menu. Right clicking triggers the "Add Node" menu option. So this PR readds the button instead.
I have to adjust the editor theme so that the button's position looks right. Otherwise it looks too far away from the right edge. This is the only place in the editor that uses
get_titlebar_hbox(), so I think the modification won't affect others.