Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple particle issues: division by zero, color ramp override, scale dependent on amount ratio #83488

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

QbieShay
Copy link
Contributor

@QbieShay QbieShay commented Oct 17, 2023

Closes #83258
Fixes scale and amount ratio being tied together
Fixes initial ramp overriding color

The last two issues were reported to me in DM

@QbieShay QbieShay added this to the 4.2 milestone Oct 17, 2023
@QbieShay QbieShay force-pushed the qbe/fix-particle-pause branch 2 times, most recently from 6fb59f8 to f629e95 Compare October 17, 2023 10:22
@QbieShay QbieShay force-pushed the qbe/fix-particle-pause branch from f629e95 to cbf75f9 Compare October 17, 2023 13:42
@Ansraer
Copy link
Contributor

Ansraer commented Oct 18, 2023

Discussed during the meeting today, we have concerns that the current random function generates numbers in a repeatable pattern. This is something we would ideally like to investigate before merging.

EDIT: I am going to brute force test the rand_from_seed function after the meeting.
EDIT 2: Ok, it would appear that rand_from_seed does properly deliver semi random numbers. I generated several thousand values and couldn't find any pattern. For now, it would appear that we need to look for the problem somewhere else.
Clay figured it out while we were talking about it, your solution is correct.

@QbieShay QbieShay changed the title Fixed division by zero in particle process Fixed multiple particle issues: division by zero, color ramp override, scale dependent on amount ratio Oct 18, 2023
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in this week's rendering meeting. Everything looks good. The concern I had over moving the AMOUNT_RATIO check turned out to be unfounded. Moving AMOUNT_RATIO is the correct fix

@akien-mga akien-mga merged commit c781694 into godotengine:master Oct 18, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Particles emit by GPUParticles2D disappear when tree is paused
5 participants