Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triangulate_delaunay() to avoid needless reallocations #83434

Merged

Conversation

Chubercik
Copy link
Contributor

@Chubercik Chubercik commented Oct 16, 2023

During the review process of the #83353 PR a certain optimization was proposed by one of the members of the Godot team; said optimization can be applied to a related function, which is what this PR accomplishes.

core/math/geometry_2d.h Outdated Show resolved Hide resolved
@Chubercik Chubercik force-pushed the optimize_triangulate_delaunay branch from a2825de to c33e291 Compare October 16, 2023 10:38
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AThousandShips AThousandShips added this to the 4.2 milestone Oct 21, 2023
@akien-mga akien-mga merged commit 14913f1 into godotengine:master Oct 22, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chubercik Chubercik deleted the optimize_triangulate_delaunay branch October 23, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants