-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove toggling of unique names in subscenes #83370
Conversation
|
ef93b28
to
439e008
Compare
Good thinking. Fixed! Though for the first issue you raised, the editor already does this, the ability to toggle the unique name off via the icon being a janky incongruity |
It's still possible to toggle unique name using shortcut. |
439e008
to
479d71d
Compare
Good catch, I forgot about the shortcut since I don't think it's assigned by default. I've added the correct handling to the tool_selected case now. It will now simply disallow any toggling to unowned nodes. It will also only pop up the error dialog if ALL the nodes in the selection are unowned by the edited scene. I think this is the right call since it will still allow big batch converts on the entire scene even if a couple of editable children get caught in the selection. |
479d71d
to
29c2615
Compare
Thanks! |
After some discussions, simply disallowing the ability to turn off the unique_name node flag in subscenes seems much more appropiate given how the system actually works. The unique name system works in the scope node ownership, so it does indeed make sense to disallow toggling it on the subscenes.
Deprecates previous attempt of fixing it here #82545