Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect check in _dict_to_surf #83056

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix incorrect check in _dict_to_surf #83056

merged 1 commit into from
Oct 9, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Oct 9, 2023 •
edited
Loading

@AThousandShips AThousandShips added this to the 4.2 milestone Oct 9, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner October 9, 2023 16:30
akien-mga
akien-mga approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to match what Clay suggested.

@akien-mga akien-mga merged commit 3d4724b into godotengine:master Oct 9, 2023
@AThousandShips AThousandShips deleted the surface_fix branch October 9, 2023 21:30
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@clayjohn clayjohn mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@clayjohn clayjohn Awaiting requested review from clayjohn

Assignees
No one assigned
Labels
bug high priority regression topic:rendering
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

mesh_add_surface ignores the dictionary's "format" key
2 participants
@AThousandShips @akien-mga