-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDScript: Fix @warning_ignore
annotation issues
#83037
GDScript: Fix @warning_ignore
annotation issues
#83037
Conversation
40936bf
to
b2b759c
Compare
b2b759c
to
2cb231a
Compare
db9580a
to
705fb79
Compare
5baf480
to
c0b4016
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR. Seems to fix a lot of issues. Maybe we could merge this PR before dev4, as it changes a lot of lines? cc. @akien-mga
c0b4016
to
11ee750
Compare
11ee750
to
b5e409b
Compare
b5e409b
to
e70cdab
Compare
Needs resyncing the docs for the |
e70cdab
to
c0ef2b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed during the GDScript meeting. Other than small nitpicks, the PR seems absolutely fine! Thanks for your hard work, @dalexeev.
c0ef2b0
to
ef1909f
Compare
Thanks! |
Thank you very much! |
@warning_ignore()
annotation don't work with all warnings #56592.@warning_ignore
s are resolved and applied in the analyzer.if
,for
,while
, etc.) applied to the first most nested statement due to a bug with recursion.PROPERTY_USED_AS_FUNCTION
,CONSTANT_USED_AS_FUNCTION
andFUNCTION_USED_AS_PROPERTY
. In 4.x properties, methods and signals share the same name scope, accessing methods without parentheses returns aCallable
.We could probably remove these warnings, since they are project settings (not real properties) and it is unlikely that anyone would use them.STANDALONE_TERNARY
(a special case that replacesSTANDALONE_EXPRESSION
, since the ternary operator can have side effects) andUNUSED_SIGNAL
warnings.@warning_ignore
inmatch
(to ignore theUNREACHABLE_PATTERN
warning).pass
inmatch
.Production edit: closes godotengine/godot-roadmap#64