Convert Nodepath properties to Object if "node_type" property hint has been set #83006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warriormaster12
force-pushed
the
filter_node_properties
branch
from
6de11bc to
f9950f7
Compare
|
Related comment, but doesn't solve the issue. |
warriormaster12
force-pushed
the
filter_node_properties
branch
from
f9950f7 to
d454fe0
Compare
scene/property_utils.cpp
Outdated
| @@ -31,8 +31,11 @@ | |||
| #include "property_utils.h" | |||
|
|
|||
| #include "core/config/engine.h" | |||
| #include "core/object/object.h" | |||
There was a problem hiding this comment.
Suggested change
| #include "core/object/object.h" |
scene/property_utils.cpp
Outdated
| #include "core/templates/local_vector.h" | ||
| #include "core/variant/array.h" |
There was a problem hiding this comment.
Suggested change
| #include "core/variant/array.h" |
scene/property_utils.cpp
Outdated
| #include "core/object/script_language.h" | ||
| #include "core/string/print_string.h" |
There was a problem hiding this comment.
Suggested change
| #include "core/string/print_string.h" |
|
Converting to draft since I realized that it wasn't as simple as I thought. Arrays are giving me currently a headache. |
warriormaster12
force-pushed
the
filter_node_properties
branch
from
d454fe0 to
6926783
Compare
|
@AThousandShips if you notice something that can be done differently, I'm all ears :) |
|
I'm currently taking a bit of a break for personal reasons so won't be able to do much complex work, but can take a look when I am able :) |
|
Yeah no worries, I just need someone more experienced with the source code than me to give feedback. You were just first one who replied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when instantiating a scene, script's properties that have "node_type" hint set are read as a nodepath causing "revert" button to popup due variant mismatch.
before pr:
2023-10-08.19-47-00.mp4
pr:
2023-10-08.19-39-25.mp4