Add compatibility rename of (v)align properties of Label

[Quimisagi]

Fixes #74493

Now when converting a project from 3 to 4, it is also renamed the align and valign properties to horizontal_align and vertical_align.

[AThousandShips]

This will break SpinBox and CheckBox which renames align -> alignment

[AThousandShips]

This needs to be done in a dedicated conversion in Label as it will break other cases otherwise, see the code for TextureRect for how to do this

[Quimisagi]

This needs to be done in a dedicated conversion in Label as it will break other cases otherwise, see the code for TextureRect for how to do this

Do you mean the TextureRect::_set(const StringName &p_name, const Variant &p_value) function?
Would it change the names of the properties in .tscn files?

[AThousandShips]

It would handle old properties stored with the old name and convert them to the new property

[Quimisagi]

Ok, I created another _set() function in Label based on the function on TextureRect but I wonder how exactly does it work?
I mean, when that _set() function is called?

[AThousandShips]

It's called in many cases but here it is relevant when a scene file is loaded

[akien-mga]

Looks good! Could you squash the commits? See PR workflow for instructions.

[AThousandShips]

If you could also update your commitmit message after squashing as the current message implies that the property was renamed, the title of the PR for example

[Quimisagi]

Done!
Can someone please approve it?

[AThousandShips]

I've already approved it? No need for further approval over the cleanup

Edit: Sorry over confusion if it was the workflow, no rush

[akien-mga]

Thanks!

[Reneator]

Thanks a lot!