Fog shader: Fix undeclared identifier global_variables
#82877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user try to use a global shader variable in a fog type shader we are getting shader error. The reason of this there is a typo in the fog.cpp. I other well working shaders types like sky the "action.global_buffer_array_variable" is "global_shader_uniforms.data". The investigation tracked here: https://discord.com/channels/212250894228652034/1158918161337434172
akien-mga
changed the title
global_variables
akien-mga
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Looks correct, this makes it consistent with other shaders and there are no other occurrences of this old name (missed in a previous rename):
$ rg "global_shader_uniforms.data"
servers/rendering/renderer_rd/environment/sky.cpp
821: actions.global_buffer_array_variable = "global_shader_uniforms.data";
servers/rendering/renderer_rd/forward_mobile/scene_shader_forward_mobile.cpp
622: actions.global_buffer_array_variable = "global_shader_uniforms.data";
servers/rendering/renderer_rd/storage_rd/particles_storage.cpp
120: actions.global_buffer_array_variable = "global_shader_uniforms.data";
servers/rendering/renderer_rd/renderer_canvas_render_rd.cpp
2495: actions.global_buffer_array_variable = "global_shader_uniforms.data";
servers/rendering/renderer_rd/forward_clustered/scene_shader_forward_clustered.cpp
719: actions.global_buffer_array_variable = "global_shader_uniforms.data";
$ rg "global_variables"
servers/rendering/renderer_rd/environment/fog.cpp
231: actions.global_buffer_array_variable = "global_variables.data";
The same issue exists in 4.1 and 4.0.
akien-mga
added
bug
topic:rendering
cherrypick:4.1
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user try to use a global shader variable in a fog type shader we are getting shader error. The reason of this there is a typo in the fog.cpp. In other well working shaders types like sky, the "action.global_buffer_array_variable" is "global_shader_uniforms.data". The investigation tracked is here:
https://discord.com/channels/212250894228652034/1158918161337434172