Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize TextEdit's inspector #82776

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Organize TextEdit's inspector #82776

merged 1 commit into from
Oct 4, 2023

Conversation

MewPurPur
Copy link
Contributor

image

@MewPurPur MewPurPur requested a review from a team as a code owner October 4, 2023 10:15
@MewPurPur MewPurPur force-pushed the more-text-edit-organization branch from a29258e to d5e5626 Compare October 4, 2023 10:17
@KoBeWi KoBeWi added this to the 4.x milestone Oct 4, 2023
@seppoday
Copy link

seppoday commented Oct 4, 2023

I know hidding stuff under subcategories is not ideal but... there is a lot of elements on that screen.

Maybe it would be good idea to drop them under subcategory?

@MewPurPur
Copy link
Contributor Author

This is the best I came up with. Do you have any ideas for better organization?

@MewPurPur MewPurPur force-pushed the more-text-edit-organization branch from d5e5626 to 38210db Compare October 4, 2023 10:24
@seppoday
Copy link

seppoday commented Oct 4, 2023 •
edited
Loading

This is the best I came up with. Do you have any ideas for better organization?

I think I've read screenshot wrong. After this PR all Highlight stuff will be under "Highlight" category that I need to unfold? If yes then ignore my comment... :D

I though you "only" changed order of stuff. Sorry...

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Oct 4, 2023 •
edited
Loading

Oh yeah sorry I didn't compile the PR as it's pretty trivial. I just edited a screenshot to show which things are now grouped under a section like the "Scroll" or the "Caret" one.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 4, 2023
akien-mga
akien-mga approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit e8e79c9 into godotengine:master Oct 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the more-text-edit-organization branch October 4, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:gui usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@MewPurPur @seppoday @akien-mga @KoBeWi