Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document worker thread pool project settings and TreeItem.uncollapse_tree() #82376

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Document worker thread pool project settings and TreeItem.uncollapse_tree() #82376

merged 1 commit into from
Feb 8, 2024

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Sep 26, 2023 •
edited
Loading

Adds some missing docs.

#76525 (comment)

@MewPurPur MewPurPur requested a review from a team as a code owner September 26, 2023 14:27
@MewPurPur MewPurPur changed the title Add missing docs for worker thread pool ProjectSettings and TreeItem.uncollapse_tree() Document worker thread pool ProjectSettings and TreeItem.uncollapse_tree() Sep 26, 2023
@AThousandShips AThousandShips added this to the 4.x milestone Sep 26, 2023
@MewPurPur
Copy link
Contributor Author

MewPurPur commented Oct 3, 2023 •
edited
Loading

@RandomShaper Could you take a look at these descs, please, if you're familiar with WorkerThreadPool?

@MewPurPur MewPurPur force-pushed the add-missing-docs branch 3 times, most recently from b6ee26f to c8a83b7 Compare October 4, 2023 10:21
@Mickeon
Copy link
Contributor

Mickeon commented Jan 16, 2024

Conflicts aside, does this PR look good? Can it be approved?

Mickeon
Mickeon approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 8, 2024
@akien-mga akien-mga changed the title Document worker thread pool ProjectSettings and TreeItem.uncollapse_tree() Document worker thread pool ProjectSettings and TreeItem.uncollapse_tree() Feb 8, 2024
@akien-mga akien-mga changed the title Document worker thread pool ProjectSettings and TreeItem.uncollapse_tree() Document worker thread pool project settings and TreeItem.uncollapse_tree() Feb 8, 2024
@akien-mga akien-mga merged commit fd6f6a0 into godotengine:master Feb 8, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the add-missing-docs branch February 8, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper left review comments

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@MewPurPur @Mickeon @akien-mga @RandomShaper @AThousandShips