POC: open Pinned Debugger Tab on project run #82277
Draft
+102
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wierdox
changed the title
|
Note that there's a PR implementing a similar feature, but with an editor setting instead of a pin button: #66503 |
|
I made a Plugin, which is like my PR but nicer on the eyes. I will update the PR to parity sometime soon. EDIT: Did so. Is basically identical to the plugin above. |
Wierdox
force-pushed
the
pinned-debug-panels
branch
3 times, most recently
from
e222caa to
ad87d60
Compare
…s two private variables to track the pinned tab index(and a public method to get that variable), and the pin button index. Added several private methods to update the logic. The button forces a tab open upon project start and overrides related editor settings. The button is updated to always be the last tab on the Debugger's tab bar.
Wierdox
force-pushed
the
pinned-debug-panels
branch
from
ad87d60 to
82e0679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proof of concept shown off in:
godotengine/godot-proposals#7848
I'll make note that for some reason the logic for auto opening Output on project run, due to editor setting
run/output/always_open_output_on_play, is done twice, once in editor_node.cpp @EditorNode::_project_run_started(), and again in script_editor_debugger.cpp @ScriptEditorDebugger::start(Ref<RemoteDebuggerPeer> p_peer). Unsure if that's nescessary for some reason or if it's an oversight.Added Pin Tab button gui to tab bar of Debugger bottom panel. Includes two private variables to track the pinned tab index(and a public method to get that variable), and the pin button index. Added several private methods to update the logic. The button forces a tab open upon project start and overrides related editor settings. The button is updated to always be the last tab on the Debugger's tab bar.