Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dark mode on Android and iOS. #82230

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Support dark mode on Android and iOS. #82230

merged 1 commit into from
Sep 26, 2023

Conversation

zaevi
Copy link
Contributor

@zaevi zaevi commented Sep 24, 2023

Implement DisplayServer.is_dark_mode_supported and DisplayServer.is_dark_mode on Android and iOS.

Have tested on OnePlus Ace2 (Android 13) and iPhone X (iOS 16.7).

@zaevi zaevi requested review from a team as code owners September 24, 2023 07:45
AThousandShips
AThousandShips reviewed Sep 24, 2023
View reviewed changes
doc/classes/DisplayServer.xml Outdated Show resolved Hide resolved
doc/classes/DisplayServer.xml Outdated Show resolved Hide resolved
platform/ios/display_server_ios.h Outdated Show resolved Hide resolved
platform/ios/display_server_ios.h Outdated Show resolved Hide resolved
@AThousandShips AThousandShips added this to the 4.x milestone Sep 24, 2023
@zaevi zaevi force-pushed the dark-mode-android-ios branch 2 times, most recently from 7cec88b to 1332784 Compare September 24, 2023 08:43
m4gr3d
m4gr3d requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Android section looks good, just some minor feedback to address.

platform/android/java/lib/src/org/godotengine/godot/Godot.kt Outdated Show resolved Hide resolved
@zaevi zaevi force-pushed the dark-mode-android-ios branch from 1332784 to 428eb13 Compare September 26, 2023 03:00
@zaevi zaevi requested a review from m4gr3d September 26, 2023 03:00
m4gr3d
m4gr3d approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Sep 26, 2023
@akien-mga akien-mga merged commit 4443b8f into godotengine:master Sep 26, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@bruvzg bruvzg bruvzg approved these changes

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
enhancement platform:android platform:ios topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@zaevi @akien-mga @m4gr3d @bruvzg @AThousandShips