Make all render driver project settings require restart

[KoTeYkA23]

Since I tested #70315 I saw that on change renderer in project settings does not offer to restart editor, so I made them restart editor 🙂

[AThousandShips]

Can you please update the comment message to match the PR title, more correct terminology, use got commit --amend and then git push --force

[KoTeYkA23]

done

[akien-mga]

I just merged #72831 which introduced some merge conflicts as it's changing the same project settings. Could you rebase to solve the merge conflicts?

[KoTeYkA23]

done

[AThousandShips]

Please squash your commits into one, see here

[KoTeYkA23]

yeah, sorry insead rebase I merged it accidently, hopefully I fixed everything

[KoTeYkA23]

oh, I accidentally remove angle hints, one sec

[AThousandShips]

You changed the wrong part of the code

[AThousandShips]

Please squash again :)

[KoTeYkA23]

done, sorry for newbie git mistakes

[AThousandShips]

It's a learning process :)

[akien-mga]

Technically, most of these settings don't really require a restart. A restart is only needed for the setting to be picked up for the editor process, but it will pick up the changed setting fine when running the game. Only the platform override which matches the editor's host platform also really warrants restarting to pick it up in the editor.

Still, it's not a bad idea to suggest a restart when changing those. I'm just slightly worried about the UX - when you change those settings, you typically need to change several of them (e.g. all platform specific overrides), and having a nagging message that one should restart the editor after you change the first, when you're meant to change several of them, might be a bit annoying. But maybe it's fine.

[KoTeYkA23]

Technically, most of these settings don't really require a restart. A restart is only needed for the setting to be picked up for the editor process, but it will pick up the changed setting fine when running the game. Only the platform override which matches the editor's host platform also really warrants restarting to pick it up in the editor.
Still, it's not a bad idea to suggest a restart when changing those. I'm just slightly worried about the UX - when you change those settings, you typically need to change several of them (e.g. all platform specific overrides), and having a nagging message that one should restart the editor after you change the first, when you're meant to change several of them, might be a bit annoying. But maybe it's fine.

Well, editor not closing forcefully, only suggest to restart, and if Godot have platform specific preprocessors we could just define restartable options only on current platform, we could ofk just platform check with default if, but I think this will be unnecessary check

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉