Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert LOD selection implementation to a previous working version #82000

Closed

Conversation

briansemrau
Copy link
Contributor

@briansemrau briansemrau commented Sep 20, 2023

Fixes #81995

See issue description for reason for reverting

May also fix #78664
Relevant to #67479

@briansemrau

This comment was marked as resolved.

@YuriSizov YuriSizov modified the milestones: 4.2, 4.x Sep 20, 2023
@Calinou Calinou added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
@mrjustaguy
Copy link
Contributor

mrjustaguy commented Sep 20, 2023

Resolves #78664 but not entirely #67479

@fire
Copy link
Member

fire commented Sep 21, 2023

I am ok with this, but I want the rendering team to take a look.

@briansemrau briansemrau force-pushed the bugfix/lod_selection_revert branch from 1b144dd to f83052b Compare September 27, 2023 04:18
@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 28, 2023
@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Nov 28, 2023
@akien-mga akien-mga requested a review from Calinou February 14, 2024 10:42
@akien-mga
Copy link
Member

akien-mga commented May 29, 2024

Superseded by #92287 and #92290.

@akien-mga akien-mga closed this May 29, 2024
@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 29, 2024
@akien-mga akien-mga removed this from the 4.3 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOD selection implementation is wrong Directional Shadow Pancake Size breaks Automatic LOD
8 participants