Fix animation when adding new Bezier track. #81987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the reported issue godotengine#81929 The issue was caused due to 'insert_queue' was prematurely set to false before awaiting dialog confirmation for track insertion. Additionally, refactored the code to eliminate redundancy and enhance code reusability.
|
To link the issue you need to put |
fire
reviewed
Sep 20, 2023
| @@ -4016,30 +4015,12 @@ Ref<Animation> AnimationTrackEditor::_create_and_get_reset_animation() { | |||
| } | |||
|
|
|||
| void AnimationTrackEditor::_confirm_insert_list() { | |||
There was a problem hiding this comment.
How are you ensuring that this code still works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the reported issue #81929
The issue was caused due to
insert_queuewas prematurely set to false before awaiting dialog confirmation for track insertion. Additionally, refactored the code to eliminate redundancy and enhance code reusability.