Fix Curve3D baking up vectors for nontrivial curves. #81885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a better macro to test for vectors being nearly equal? CHECK_EQ is nice because it shows the precise values that are incorrect, but it's inappropriate for precise floating checks. |
TokageItLab
reviewed
Sep 18, 2023
|
The bug is also present in 4.1, should be safe for cherry-picking? 🤔 |
kleonc
added
the
cherrypick:4.1
TokageItLab
approved these changes
Sep 19, 2023
rmmh
force-pushed
the
fix-curve3d-twisting
branch
from
9076147 to
35add14
Compare
The code was modified in 42aa539 to have a different basis vector, but this line was missed and caused up vectors to invert sometimes. Fixes godotengine#81879
rmmh
force-pushed
the
fix-curve3d-twisting
branch
from
35add14 to
734b9d2
Compare
akien-mga
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Looks good to me.
As this bug got popular on Twitter, I'll clarify that even though this will be merged in a bit, it won't make the cut for 4.2-dev5 which was built yesterday (even though we'll release it today).
It should be in 4.2-dev6 and likely 4.1.2 RC 1.
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was modified in 42aa539 to have a different basis vector, but this line was missed and caused up vectors to invert sometimes.
Fixes #81879
One-character bugfix by @kleonc, bisection and test case by me.