Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thorvg: Update to 0.10.7 #81862

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

@akien-mga akien-mga added this to the 4.2 milestone Sep 18, 2023
@akien-mga akien-mga requested review from a team as code owners September 18, 2023 12:50
@akien-mga akien-mga force-pushed the thorvg-0.10.6 branch 2 times, most recently from 76b8b68 to 8b3fcc3 Compare September 18, 2023 13:45
@akien-mga
Copy link
Member Author

CC @capnm

@capnm
Copy link
Contributor

capnm commented Sep 22, 2023

ThorVG v0.10.7:

@SlugFiller
Copy link
Contributor

So.... 0.10.7 PR and merge when? Because it's really hard to make/maintain my own PRs on top of a master that doesn't compile.

@akien-mga akien-mga changed the title thorvg: Update to 0.10.6 thorvg: Update to 0.10.7 Sep 26, 2023
@akien-mga
Copy link
Member Author

Here's 0.10.7.

@capnm
Copy link
Contributor

capnm commented Sep 27, 2023

So.... 0.10.7 PR and merge when? Because it's really hard to make/maintain my own PRs on top of a master that doesn't compile.
Here's 0.10.7.

@SlugFiller could you check if it fixes your issue?
I am currently trying to help by making a 0.11 release PR
thorvg/thorvg#1680 (comment)
and don't know what @akien-mga decides to do with this PR.

@akien-mga
Copy link
Member Author

We can merge that one if it's fine, or wait for 0.11 if it's imminent, I'm fine either way.

@SlugFiller
Copy link
Contributor

SlugFiller commented Sep 27, 2023

Confirmed the editor builds if I cherry pick this. (And combine with a fix for #82322, but that's a different topic)

P.S. I wouldn't be tripping on any of these issues if #77233 was merged instead.

@akien-mga akien-mga merged commit 214c978 into godotengine:master Sep 27, 2023
@akien-mga akien-mga deleted the thorvg-0.10.6 branch September 27, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing on MSVC 2017
3 participants