Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify filtering by node type and group in the Scene tree dock #81675

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 15, 2023

This functionality has been available since 4.0, but was difficult to discover since there was no tooltip and the placeholder didn't mention it.

Preview

To make the most important part of it (t:type) squeeze within the default dock width, I had to be a little creative, but it should be self-explanatory enough:

image

@Calinou Calinou requested a review from a team as a code owner September 15, 2023 00:22
@Calinou Calinou added this to the 4.2 milestone Sep 15, 2023
@KoBeWi
Copy link
Member

KoBeWi commented Sep 15, 2023

Filtering is available from the ⋮ menu.

@YuriSizov
Copy link
Contributor

Filtering is available from the ⋮ menu.

I don't think that the hint in the placeholder (and a tooltip) hurts, though, does it?

@KoBeWi
Copy link
Member

KoBeWi commented Sep 15, 2023

It was more response to "was difficult to discover since there was no tooltip and the placeholder didn't mention it.".
I think tooltip wouldn't hurt. Not sure about placeholder, as it can't fit all filter options.

@Calinou
Copy link
Member Author

Calinou commented Sep 22, 2023

I've changed the placeholder to also mention g:group. At the default width, it's conveniently hidden, but you'll see it if you resize the dock's width:

image

image

@Calinou Calinou force-pushed the editor-filter-nodes-type-clarify branch from 77cc7e1 to f9400a4 Compare September 22, 2023 21:09
@Calinou Calinou changed the title Clarify filtering by node type in the Scene tree dock Clarify filtering by node type and group in the Scene tree dock Sep 22, 2023
This functionality has been available since 4.0, but was difficult
to discover since there was no tooltip and the placeholder didn't
mention it.
@Calinou Calinou force-pushed the editor-filter-nodes-type-clarify branch from f9400a4 to edade7d Compare September 22, 2023 21:09
@akien-mga akien-mga merged commit 5b6bf2a into godotengine:master Sep 24, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-filter-nodes-type-clarify branch September 25, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants