Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SubViewport with UPDATE_WHEN_VISIBLE not working properly in exported project #81607

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Sep 13, 2023

The issue is primarily due to RSG::texture_storage->render_target_was_used() returning inconsistent results in the editor and exported projects.

Fix #81173, fix #80636.

…exported project

The issue is primarily due to `RSG::texture_storage->render_target_was_used()`
returning inconsistent results in the editor and exported projects.
@saierXP
Copy link

saierXP commented Sep 21, 2023

It works for me.

Before After
Testt_bwVPGvS3YK Testt_wh8el2SyKD

@akien-mga akien-mga requested a review from clayjohn September 21, 2023 12:42
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, that was a silly mistake.

Looks good to me!

@akien-mga akien-mga merged commit c255ace into godotengine:master Oct 5, 2023
@akien-mga
Copy link
Member

Thanks!

@Rindbee Rindbee deleted the fix-UPDATE_WHEN_VISIBLE-not-work-in-exported-project branch October 5, 2023 08:25
@AThousandShips AThousandShips added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 28, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants