-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDScript: Add module description in markdown #81345
Conversation
a72658f
to
a6d0138
Compare
511c2e2
to
6370f43
Compare
a128e07
to
3f490fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I didn’t know much of this or wasn’t completely sure. I've added some suggestions, you don't have to follow them all, these are just ideas that might inspire you.
The README is intended for new contributors, so it's quite difficult to decide which details are important to understand the module and which will require learning the code anyway, so it's not worth the effort.
In my opinion, a section about tests would help new contributors. There is a doc page, but it is mainly about doctest
, not about GDScript tests. It would be nice to briefly explain that tests should be positive and negative, how our files are located (folders, *.gd
, *.notest.gd
, *.out
), how to run tests locally.
I hope Adam, Dmitry and George will add their suggestions too.
@dalexeev excellent comments! I will try to find some time soon to incorporate them! I think a section about tests makes a lot of sense, and we can link to the official docs about it! |
7729e01
to
b8de8a4
Compare
Incorporated all of @dalexeev's suggestions! They were so helpful and relevant! 🥰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing write-up, I learned a lot :)
Thanks, it's all I'm capable of doing at the moment, but it sounds like folks might find it helpful, so that feels nice :) It might eventually make sense to add a section on how unit tests are run, but that requires digging more deeply into that code, which I haven't done in a while :) |
Spent a few more hours on this today. I think it's good to merge if folks don't find anything else they'd like changed. Changelog:
I think it's helpful for this document to describe a few of the things the analyzer actually does. This means that new contributors don't need to work through a couple hundred lines of code to try to figure it out - they can read it and get a general idea for what it does, and then read the code with more context in mind. |
May I poke this? It looks great to me. Would be nice to have sooner than later for the developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Of course, there is always more to add, but we are not trying to write exhaustive internal documentation. This is a good overview for new contributors, and we can edit it later anyway (unless @vnen, @adamscott, @vonagam, and other contributors have suggestions right now). @anvilfolk Thank you again for the great write-up!
Thanks! Great writeup :) |
This adds a .md file to the GDScript module that gives a moderately in-depth description of how the module is organized, used, main classes, etc :)