Better respect auto-translation of static strings #81180
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that GUI nodes make heavy use of RTR. It has 2 problems:
auto_translate
is disabledI changed RTR to TTRC where internal auto-translation can be used (Buttons and PopupMenus; since #75012 it works even in the editor). For dynamic strings I added a new
ATR()
function, which is the same as already existingatr()
, but it's used for strings that should be fetched for translation.Partially addresses #80549 If we make
auto_translate
propagated, this PR is required to make it actually work.Note that we need to add ATR to the translation fetch list (I think it's done on the translation repo?)