Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Signal Connection Dock improvements #81092

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Editor: Signal Connection Dock improvements #81092

merged 1 commit into from
Aug 29, 2023

Conversation

dalexeev
Copy link
Member

  • Add icons.
  • Add "Open Documentation" context menu item.

@dalexeev dalexeev added this to the 4.2 milestone Aug 28, 2023
@dalexeev dalexeev requested review from a team August 28, 2023 20:32
dalexeev
dalexeev commented Aug 28, 2023
View reviewed changes
editor/connections_dialog.cpp
Comment on lines -1133 to +1147
signal_menu->set_item_disabled(slot_menu->get_item_index(DISCONNECT_ALL), disable_disconnect_all);
signal_menu->set_item_disabled(signal_menu->get_item_index(DISCONNECT_ALL), disable_disconnect_all);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, but this is obviously a bug.

Copy link
Contributor

@MewPurPur MewPurPur Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be the cause of "Disconnect" sometimes being inconsistent between the bottom button and the right-click menu. Hooray?

@dalexeev dalexeev force-pushed the editor-improve-signal-connection-dock branch from f6e9206 to 8efa3ce Compare August 29, 2023 07:00
Calinou
Calinou approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

@MewPurPur
Copy link
Contributor

(missed a review comment, I didn't test it but the code looks excellent to me)

@akien-mga akien-mga merged commit 571aa7f into godotengine:master Aug 29, 2023
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the editor-improve-signal-connection-dock branch August 29, 2023 13:01
@dalexeev dalexeev mentioned this pull request Sep 1, 2023
Merged
@KoBeWi KoBeWi mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MewPurPur MewPurPur MewPurPur approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@dalexeev @MewPurPur @akien-mga @Calinou