Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup special case of cluster render #81081

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

RandomShaper
Copy link
Member

This is a fixup for #76832. Either something has changed that requires this change or it shouldn't have worked at all without it (weird, because it did work). In any case, it makes a lot of sense to add this code line and things work as expected again with it.

@RandomShaper RandomShaper added bug topic:rendering topic:porting cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 28, 2023
@RandomShaper RandomShaper added this to the 4.2 milestone Aug 28, 2023
@RandomShaper RandomShaper requested a review from a team as a code owner August 28, 2023 17:02
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga merged commit 7792f9e into godotengine:master Aug 29, 2023
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fixup_cluster_special branch August 29, 2023 13:29
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants