-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow finite numbers in Range.value
.
#81076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does this solve #80755 for manually edited values in the files? Otherwise I think a dedicated fix is required, including if broken past versions exist |
By manually editing you can make the scene completely unopenable in the editor, so I don't think it's a concern. We should only make sure that the data saved by the editor itself is valid. |
To be clear about what I said there, I've only broken my scenes before because I was goofing around and seeing how much I can break Godoh - not intentionally. |
Thanks! |
This caused a regression in the editor, which uses |
Fixes #81057.
Since this property represents a number in a range, it doesn't make sense for it to be inf or nan.
Bugsquad edit: Fixes #80755