-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhysicsMaterial icon #81044
Add PhysicsMaterial icon #81044
Conversation
add218f
to
1d0533c
Compare
Should the 3 lines at the top be blue, similar to other physics-related classes? Other than that, this looks great to me 🙂 |
Might be a good idea, I'm thinking maybe the whole top surface should be blue too, to highlight the relevant part. |
Sounds good. |
@MewPurPur I've never used this resource before but from the docs it looks like it changes the properties of the whole body, so I feel like it may be a bit misleading to highlight only the top in blue. Would it work if we made the whole thing blue? |
1d0533c
to
b4ebddf
Compare
I pushed the version with a bit of blue. I know PhysicsMaterial changes all surfaces, but icons should be intrinsic, rather than declarative. It's not necessary (or productive) to need the icons to be very accurate. The whole thing can't be blue because that's reserved for Shape2D and Shape3D resources, which this shouldn't look similar to. |
I feared that. Oh well. The bit of blue it's definitely the best option then IMO. |
b4ebddf
to
0095205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Thanks! |
It's the class that determines the friction and bounciness of surfaces.