Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PhysicsMaterial icon #81044

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Aug 27, 2023

image

It's the class that determines the friction and bounciness of surfaces.

@MewPurPur MewPurPur requested a review from a team as a code owner August 27, 2023 13:47
@AThousandShips AThousandShips added this to the 4.x milestone Aug 27, 2023
@MewPurPur MewPurPur force-pushed the add-physics-material-icon branch from add218f to 1d0533c Compare August 27, 2023 14:01
@Calinou
Copy link
Member

Calinou commented Aug 27, 2023

Should the 3 lines at the top be blue, similar to other physics-related classes?

Other than that, this looks great to me 🙂

@MewPurPur
Copy link
Contributor Author

Might be a good idea, I'm thinking maybe the whole top surface should be blue too, to highlight the relevant part.

@Calinou
Copy link
Member

Calinou commented Aug 27, 2023

Might be a good idea, I'm thinking maybe the whole top surface should be blue too, to highlight the relevant part.

Sounds good.

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Aug 28, 2023

image

I like it less personally. I haven't pushed it yet. What do you think?

@Riteo
Copy link
Contributor

Riteo commented Aug 29, 2023

@MewPurPur I've never used this resource before but from the docs it looks like it changes the properties of the whole body, so I feel like it may be a bit misleading to highlight only the top in blue.

Would it work if we made the whole thing blue?

@MewPurPur MewPurPur force-pushed the add-physics-material-icon branch from 1d0533c to b4ebddf Compare August 29, 2023 06:40
@MewPurPur
Copy link
Contributor Author

MewPurPur commented Aug 29, 2023

I pushed the version with a bit of blue.

I know PhysicsMaterial changes all surfaces, but icons should be intrinsic, rather than declarative. It's not necessary (or productive) to need the icons to be very accurate.

The whole thing can't be blue because that's reserved for Shape2D and Shape3D resources, which this shouldn't look similar to.

@Riteo
Copy link
Contributor

Riteo commented Aug 29, 2023

@MewPurPur

The whole thing can't be blue because that's reserved for Shape2D and Shape3D resources, which this shouldn't look similar to.

I feared that. Oh well. The bit of blue it's definitely the best option then IMO.

@MewPurPur MewPurPur force-pushed the add-physics-material-icon branch from b4ebddf to 0095205 Compare September 20, 2023 21:05
@MewPurPur
Copy link
Contributor Author

image

Changed it to this because the blue is meant to be a highlight and looked bad in light theme.

Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jan 4, 2024
@akien-mga akien-mga merged commit 1aa03f7 into godotengine:master Jan 4, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the add-physics-material-icon branch January 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants