Fix Vulkan texture update #80781
Merged
Fix Vulkan texture update #80781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
cherrypick:4.0
cherrypick:4.1
|
Staging buffer and other common code will be unified eventually. but in the meantime this PR is needed. The original fix was proposed here: #64304 (review). I didn't realize it could be crossported to Vulkan. |
RandomShaper
approved these changes
Aug 21, 2023
clayjohn
approved these changes
Aug 21, 2023
|
Thanks! |
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some non-4 byte aligned or compressed image formats (like FORMAT_RH, FORMAT_RG8 or COMPRESS_S3TC with USED_CHANNELS_RG etc.) the staging buffer calculation was off because possible alignment adjustment offset was not taken into account. This sometimes made the last pixel in an image corrupt when uploaded to GPU. Also see
RenderingDeviceVulkan::_buffer_update()which does this same calculation correctly.edit:
This fix proably needs to be done in #80164
RenderingDeviceVulkan::_texture_update_partial()too. Interestingly, this issue is fixed in Direct3D 12 PR #70315 inRenderingDeviceD3D12::_texture_update().