Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tiny spelling error in NavigationAgent2D docs #80474

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Fixed tiny spelling error in NavigationAgent2D docs #80474

merged 1 commit into from
Aug 10, 2023

Conversation

Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Aug 10, 2023

Description

Fixes #80468
Fixed the small spelling mistake in line 183 (https://github.com/godotengine/godot/blob/master/doc/classes/NavigationAgent2D.xml)

@Sai-Suraj-27 Sai-Suraj-27 requested a review from a team as a code owner August 10, 2023 06:43
@akien-mga akien-mga added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 10, 2023
@akien-mga akien-mga added this to the 4.2 milestone Aug 10, 2023
@akien-mga
Copy link
Member

Confirmed that it's the only occurrence of a too + present participle typo in the docs:

$ rg -g'*.xml' "too [a-z]+ing"
doc/classes/NavigationAgent2D.xml
183:                    The distance threshold before a path point is considered to be reached. This allows agents to not have to hit a path point on the path exactly, but only to reach its general area. If this value is set too high, the NavigationAgent will skip points on the path, which can lead too leaving the navigation mesh. If this value is set too low, the NavigationAgent will be stuck in a repath loop because it will constantly overshoot or undershoot the distance to the next point on each physics frame update.

@akien-mga akien-mga merged commit 5ba3456 into godotengine:master Aug 10, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga changed the title Fixed tiny spelling error in doc\classes\NavigationAgent2D.xml Fixed tiny spelling error in NavigationAgent2D docs Sep 5, 2023
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 21, 2023
@YuriSizov
Copy link
Contributor

YuriSizov commented Sep 21, 2023

Will skip from cherry-picking as this would invalidate the translation of the entire description. It's an unfortunate typo, but a minor issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiny spelling error in NavigationAgent2D Tooltip
3 participants