Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify make dir and duplicate dialogs #80473

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 10, 2023

When duplicating a file/folder, there is this bare-bones dialog with just name input. I wanted to enhance it a bit, but noticed that DirectoryCreateDialog is very similar, so I just unified them.

  • DirectoryCreateDialog (name pending) now supports file and directory mode and
  • the dialog now takes a callback, which is called after accepting. It sends the validated path as argument
  • creating new directory was adapted to the new dialog
  • when you duplicate file, the new DirectoryCreateDialog will be used for validation (instead of validating after accepting 🤦‍♂️)
  • you can now duplicate the file into another directory, which will be created if it doesn't exist
9SwvcD37u5.mp4

This will also allow to unhack #79966

Note that the PR is ready for review, but I still need to rename DirectoryCreateDialog into something that makes more sense with the new functionality.

@KoBeWi KoBeWi requested a review from a team as a code owner August 10, 2023 06:24
@KoBeWi KoBeWi added this to the 4.x milestone Aug 10, 2023
@YuriSizov
Copy link
Contributor

YuriSizov commented Aug 10, 2023

I can propose something like EditorCopyMoveDialog, referring to the cp and mv commands which are closely related to the functionality here. It doesn't cover the create portion, but it doesn't sound too terrible IMO. And helps to distinguish it from the big, full-featured file dialog.

@KoBeWi KoBeWi force-pushed the they're_the_same_picture branch from 449028c to 6455ccc Compare February 25, 2024 14:58
@KoBeWi KoBeWi requested review from a team as code owners February 25, 2024 14:58
@KoBeWi KoBeWi force-pushed the they're_the_same_picture branch from 6455ccc to e2a96dd Compare October 2, 2024 12:57
@KoBeWi KoBeWi requested a review from a team as a code owner October 2, 2024 12:57
@KoBeWi KoBeWi modified the milestones: 4.x, 4.4 Oct 2, 2024
@akien-mga akien-mga merged commit 3b41f73 into godotengine:master Oct 3, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants