-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly load multiple action sets in XR #80419
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
28aaff3
to
0cd8b93
Compare
This should be a complete fix for the bug unless I missed something. |
0cd8b93
to
182d51a
Compare
Please amend the commit message to be closer to the project's preferred style. The current title of the PR is a good option. We don't prefix commits/PR titles with |
182d51a
to
688b1de
Compare
I'm going to double check this with OpenXR because it should be possible to attach action sets one at a time, it shouldn't clear previously attached action sets... |
No, I'm definately wrong, I don't know if this was a restriction added after I build this or if it is something else but:
in https://registry.khronos.org/OpenXR/specs/1.0/man/html/xrAttachSessionActionSets.html |
688b1de
to
a60cf6e
Compare
Thanks! |
This pull request addresses an issue where Godot was unable to correctly load multiple action sets. Previously, only the first action set was loaded, and any subsequent attempts would result in an error, indicating that the action sets were already loaded.
This fix ensures that multiple action sets can be loaded without errors