Expose PlaceHolderScriptInstance to GDExtension #80394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiself
force-pushed
the
expose-placeholder-script-instance-to-gde
branch
2 times, most recently
from
91055ac to
9c2651a
Compare
dsnopek
reviewed
Aug 8, 2023
maiself
force-pushed
the
expose-placeholder-script-instance-to-gde
branch
2 times, most recently
from
6e04259 to
6ca7ced
Compare
dsnopek
requested changes
Aug 28, 2023
There was a problem hiding this comment.
I've started messing around with this with godot-cpp, and I think it'd be sufficient for my cppscript experiment.
I also spent some time reading through the Luau binding's code, and I think this would be sufficient for its purposes as well.
However, I noticed a small naming issue which is pointed out in the code comments. But after that is fixed, I think I'm personally happy with this PR!
Co-authored-by: David Snopek <[email protected]>
maiself
force-pushed
the
expose-placeholder-script-instance-to-gde
branch
from
70e98a2 to
4b5da7e
Compare
|
Fixed the naming issue and rebased on |
dsnopek
approved these changes
Aug 28, 2023
|
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
PlaceHolderScriptInstanceused by thegdscriptandcsharp_scriptmodules in Godot to GDExtension.While use of this class is technically optional as placeholder implementation can be done with the existing interface, exposing it allows extensions to avoid reimplementing the entire behavior.
This would likely be useful for existing language bindings:
ScriptInstanceimplementation and disabledcallwhen used as a placeholder.PlaceHolderScriptInstanceI've started using this in my Python bindings and it seems to work quite well. Without this I would be doing what has been done for the luau bindings.