Fix Windows console wrapper and icon being swapped #80357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
approved these changes
Aug 7, 2023
|
Link back to the issue itself #80238 |
akien-mga
changed the title
|
When squashing the commits, please also amend the commit message to match the usual format of Godot commits, e.g.: |
akien-mga
added
the
cherrypick:4.1
OXTyler
force-pushed
the
master
branch
2 times, most recently
from
f2a7f2a to
c1c4b26
Compare
|
Please squash your commits into one |
akien-mga
approved these changes
Aug 9, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue where when exporting on a windows system, the console wrapper icon and normal one would be swapped, this was fixed because the boolean value for if the icon was the console wrapper icon or not was backwards in the modify_template function
Bugsquad edit: