Remove exp hint of a few properties #80326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorSpinSlider, used for our properties, extends Range, and it likewise doesn't work if min is
0
or less, yet we have a few dozen properties that use exp and start with0
.I wanted to add support for some kind of exponential easing without these restraints, but I'm not sure if I'll finish it, so I just wanted to start with removing a few "exp" hints where exponential easing doesn't make much sense.
First is CameraAttributes, where the min value of DOF near/far transition is
-1
and so the exp hint didn't work in the editor. I assume-1
is something representing an invalid value.Second is CSGShape, where the min value of angle simplification is
0
, meaning no angle simplifications will be made. I get how you're likely to want smaller angle simplifications rather than big ones towards the max value 180, but I don't think exponential easing makes sense here, as it's something you use when different common values of a property are orders of magnitude apart.