Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix physics server force integration docs #80166

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

rburing
Copy link
Member

@rburing rburing commented Aug 2, 2023

Removed incorrect information, added correct information. Based on #79977 (comment) and added more details.

cc @mihe

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar suggestions for the PhysicsServer3D equivalents, too

doc/classes/PhysicsServer2D.xml Outdated Show resolved Hide resolved
doc/classes/PhysicsServer2D.xml Show resolved Hide resolved
doc/classes/PhysicsServer2D.xml Outdated Show resolved Hide resolved
doc/classes/PhysicsServer2D.xml Outdated Show resolved Hide resolved
@rburing rburing force-pushed the force_integration_docs branch 2 times, most recently from 06825d9 to 4be7849 Compare March 15, 2024 22:41
@rburing
Copy link
Member Author

rburing commented Mar 15, 2024

Thanks for the thorough reviews! I've standardized on "standard force integration" now, as a natural counterpart to "custom" (the word which I also added in the documentation now, inspired by the documentation of rendering callbacks).

Note PhysicsDirectBodyState2D.integrate_forces does something different, which is now also documented correctly.

Edit: I'm not a huge fan of the (pre-existing) "gravity and air friction" mention as it is, please feel free to suggest an improvement.

@mihe
Copy link
Contributor

mihe commented Mar 15, 2024

The "air friction" part should probably be replaced with "damping", like you've already done with PhysicsDirectBodyState*D.integrate_forces.

@rburing rburing force-pushed the force_integration_docs branch from 4be7849 to e5632b0 Compare March 15, 2024 23:32
@rburing rburing requested a review from Mickeon March 23, 2024 23:41
@akien-mga akien-mga merged commit 4403856 into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@rburing rburing deleted the force_integration_docs branch April 8, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants