Fix display of embedded Window
#80121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-embedded-window-stretch
branch
from
321f810 to
36ddfc7
Compare
Sauermann
force-pushed
the
fix-embedded-window-stretch
branch
from
36ddfc7 to
4bcd1da
Compare
Sauermann
changed the title
WindowWindow
clayjohn
added
the
cherrypick:4.3
Geometror
reviewed
Dec 16, 2024
Sauermann
force-pushed
the
fix-embedded-window-stretch
branch
from
4bcd1da to
69b30e6
Compare
Fix Rect of texture to take window and stretch transform into account. There is no need for `viewport_attach_to_screen` for embedded windows, since their display is handled via `Viewport::_sub_window_update`.
Sauermann
force-pushed
the
fix-embedded-window-stretch
branch
from
69b30e6 to
0eff41d
Compare
Geometror
approved these changes
Dec 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Rect of texture to take window and stretch transform into account.
resolve #66809
resolve part of #72760
MRP: WindowsTestbed.zip (run and set "Window height" to 150)
There is no need for
viewport_attach_to_screenfor embedded windows, since their display is handled viaViewport::_sub_window_update.Updated 2023-08-05: Draw black bars at the sides, that aren't covered by the content.
Updated 2024-12-16: Rebased on master for good measure. insert
constexpression, fix rounding issue.